Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add subfigure_mosaic method to FigureBase for creating subfigure layouts #28508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
Loading
from

Conversation

vineethsaivs
Copy link

Implemented subfigure_mosaic method to build complex GridSpec layouts using ASCII art or nested lists. This method supports shared axes, custom width and height ratios, and empty sentinel handling for creating a layout of SubFigures within a figure.

PR summary

This change allows users to create intricate subfigure layouts within a matplotlib figure, enhancing the flexibility and usability of the plotting library. The new feature enables the creation of subfigures using a mosaic layout, providing more control over the figure design.

PR checklist

Implemented subfigure_mosaic method to build complex GridSpec layouts
using ASCII art or nested lists. This method supports shared axes,
custom width and height ratios, and empty sentinel handling for creating
a layout of SubFigures within a figure.
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@jklymak
Copy link
Member

jklymak commented Jul 4, 2024

I'm not sure such a feature is really wanted, but even if it is, you appear to have removed subplot_mosaic which obviously has to stay.

@jklymak jklymak added the status: needs clarification Issues that need more information to resolve. label Jul 4, 2024
@timhoffm
Copy link
Member

timhoffm commented Jul 4, 2024

To me this feels like YAGNI. Do you have concrete examples where this will help?

@rcomer
Copy link
Member

rcomer commented Jul 4, 2024

This would close #25949. Note that there is an existing orphaned PR #26061.

I haven’t looked at the detail but #28170 (comment) suggests we might need #28177 first.

@jklymak
Copy link
Member

jklymak commented Jul 6, 2024

I'll move this to draft as its not ready for review.

@jklymak jklymak marked this pull request as draft July 6, 2024 15:33
@tacaswell
Copy link
Member

Where #26061 got stuck was the inability to easily get the "first parent" figure.

@tacaswell
Copy link
Member

I'm in favor of this feature, (although I don't think that it needs to support sharex/sharey) either via this PR or the other one (on first glance I'm partial to the other one, but that may just be familiarity).

I think dropping subplot_mosaic was a typo (as subfigure_mosaic is defined twice).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Needs decision
Development

Successfully merging this pull request may close these issues.

5 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.