Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

flip subfigures axes to match subplots #28363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 13, 2024
Merged

flip subfigures axes to match subplots #28363

merged 2 commits into from
Jun 13, 2024

Conversation

saranti
Copy link
Contributor

@saranti saranti commented Jun 9, 2024 •
edited
Loading

PR summary

Closes #28344. Change the iteration order on the rows and columns of subfigure to draw them in row-major order.

PR checklist

@saranti saranti marked this pull request as draft June 9, 2024 07:04
rcomer
rcomer reviewed Jun 9, 2024
View reviewed changes
lib/matplotlib/figure.py Outdated Show resolved Hide resolved
@saranti saranti marked this pull request as ready for review June 12, 2024 05:26
@tacaswell tacaswell added this to the v3.10.0 milestone Jun 12, 2024
tacaswell
tacaswell reviewed Jun 12, 2024
View reviewed changes
doc/api/next_api_changes/behavior/28363-TS.rst Outdated Show resolved Hide resolved
tacaswell
tacaswell reviewed Jun 12, 2024
View reviewed changes
lib/matplotlib/tests/test_figure.py Outdated Show resolved Hide resolved
@tacaswell
Copy link
Member

The API note should be a bit clearer about the effect of the change (as it is only in the list view of the sub figures that we see it) and I suggested a simpler test.

rcomer
rcomer reviewed Jun 13, 2024
View reviewed changes
Copy link
Member

@rcomer rcomer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have a tiny wording suggestion as this parses better for me. Otherwise, looks good to me.

doc/api/next_api_changes/behavior/28363-TS.rst Outdated Show resolved Hide resolved
rcomer
rcomer approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@rcomer rcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyone can merge when CI is green.

@rcomer rcomer merged commit 54729db into matplotlib:main Jun 13, 2024
41 of 42 checks passed
@tacaswell
Copy link
Member

Trying to track down the test coverage failure, it is because one of the GHA jobs (3.9 on macOS) failed to upoload:

Run codecov/codecov-action@v4
  with:
    name: 3.9 macos-12 
  env:
    NO_AT_BRIDGE: 1
    OPENBLAS_NUM_THREADS: 1
    PYTHONFAULTHANDLER: 1
    pythonLocation: /Users/runner/hostedtoolcache/Python/3.9.19/x64
    PKG_CONFIG_PATH: /Users/runner/hostedtoolcache/Python/3.9.19/x64/lib/pkgconfig
    Python_ROOT_DIR: /Users/runner/hostedtoolcache/Python/3.9.19/x64
    Python2_ROOT_DIR: /Users/runner/hostedtoolcache/Python/3.9.19/x64
    Python3_ROOT_DIR: /Users/runner/hostedtoolcache/Python/3.9.19/x64
evenName: pull_request
baseRef: matplotlib:main | headRef: saranti:subfigincolumn
==> Fork detected, tokenless uploading used
evenName: pull_request
baseRef: matplotlib:main | headRef: saranti:subfigincolumn
==> Fork detected, tokenless uploading used
evenName: pull_request
baseRef: matplotlib:main | headRef: saranti:subfigincolumn
==> Fork detected, tokenless uploading used
==> macos OS detected
https://cli.codecov.io/latest/macos/codecov.SHA256SUM
gpg: directory '/Users/runner/.gnupg' created
gpg: /Users/runner/.gnupg/trustdb.gpg: trustdb created
gpg: key 806BB28AED779869: public key "Codecov Uploader (Codecov Uploader Verification Key) <security@codecov.io>" imported
gpg: Total number processed: 1
gpg:               imported: 1
gpg: Signature made Wed May  8 17:49:39 2024 UTC
gpg:                using RSA key 27034E7FDB850E0BBC2C62FF806BB28AED779869
gpg: Good signature from "Codecov Uploader (Codecov Uploader Verification Key) <security@codecov.io>" [unknown]
gpg: WARNING: This key is not certified with a trusted signature!
gpg:          There is no indication that the signature belongs to the owner.
Primary key fingerprint: 2703 4E7F DB85 0E0B BC2C  62FF 806B B28A ED77 9869
==> Uploader SHASUM verified (fe4bddf5245ee90e516f56a9e8e169ff4f1e84e0850bfaf0f802481e1072b9ca  codecov)
==> Running version latest
==> Running version v0.6.0
==> Running git config --global --add safe.directory /Users/runner/work/matplotlib/matplotlib
/usr/local/bin/git config --global --add safe.directory /Users/runner/work/matplotlib/matplotlib
==> Running command '/Users/runner/work/_actions/codecov/codecov-action/v4/dist/codecov create-commit'
/Users/runner/work/_actions/codecov/codecov-action/v4/dist/codecov create-commit --git-service github -C 3e0902ca634ee1b94233e4441118f517414cb030
info - 2024-06-13 15:22:17,992 -- ci service found: github-actions
Error: Codecov token not found. Please provide Codecov token with -t flag.
Warning: Codecov: Failed to properly create commit: The process '/Users/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1


Run codecov/codecov-action@v4
  with:
    name: 3.12 macos-14 
  env:
    NO_AT_BRIDGE: 1
    OPENBLAS_NUM_THREADS: 1
    PYTHONFAULTHANDLER: 1
    pythonLocation: /Users/runner/hostedtoolcache/Python/3.12.3/arm64
    PKG_CONFIG_PATH: /Users/runner/hostedtoolcache/Python/3.12.3/arm64/lib/pkgconfig
    Python_ROOT_DIR: /Users/runner/hostedtoolcache/Python/3.12.3/arm64
    Python2_ROOT_DIR: /Users/runner/hostedtoolcache/Python/3.12.3/arm64
    Python3_ROOT_DIR: /Users/runner/hostedtoolcache/Python/3.12.3/arm64
evenName: pull_request
baseRef: matplotlib:main | headRef: saranti:subfigincolumn
==> Fork detected, tokenless uploading used
evenName: pull_request
baseRef: matplotlib:main | headRef: saranti:subfigincolumn
==> Fork detected, tokenless uploading used
evenName: pull_request
baseRef: matplotlib:main | headRef: saranti:subfigincolumn
==> Fork detected, tokenless uploading used
==> macos OS detected
https://cli.codecov.io/latest/macos/codecov.SHA256SUM
gpg: directory '/Users/runner/.gnupg' created
gpg: /Users/runner/.gnupg/trustdb.gpg: trustdb created
gpg: key 806BB28AED779869: public key "Codecov Uploader (Codecov Uploader Verification Key) <security@codecov.io>" imported
gpg: Total number processed: 1
gpg:               imported: 1
gpg: Signature made Wed May  8 17:49:39 2024 UTC
gpg:                using RSA key 27034E7FDB850E0BBC2C62FF806BB28AED779869
gpg: Good signature from "Codecov Uploader (Codecov Uploader Verification Key) <security@codecov.io>" [unknown]
gpg: WARNING: This key is not certified with a trusted signature!
gpg:          There is no indication that the signature belongs to the owner.
Primary key fingerprint: 2703 4E7F DB85 0E0B BC2C  62FF 806B B28A ED77 9869
==> Uploader SHASUM verified (fe4bddf5245ee90e516f56a9e8e169ff4f1e84e0850bfaf0f802481e1072b9ca  codecov)
==> Running version latest
==> Running version v0.6.0
==> Running git config --global --add safe.directory /Users/runner/work/matplotlib/matplotlib
/opt/homebrew/bin/git config --global --add safe.directory /Users/runner/work/matplotlib/matplotlib
==> Running command '/Users/runner/work/_actions/codecov/codecov-action/v4/dist/codecov create-commit'
/Users/runner/work/_actions/codecov/codecov-action/v4/dist/codecov create-commit --git-service github -C 3e0902ca634ee1b94233e4441118f517414cb030
info - 2024-06-13 15:18:09,779 -- ci service found: github-actions
info - 2024-06-13 15:18:10,381 -- The PR is happening in a forked repo. Using tokenless upload.
info - 2024-06-13 15:18:10,544 -- Process Commit creating complete
==> Running command '/Users/runner/work/_actions/codecov/codecov-action/v4/dist/codecov create-report'
/Users/runner/work/_actions/codecov/codecov-action/v4/dist/codecov create-report --git-service github -C 3e0902ca634ee1b94233e4441118f517414cb030
info - 2024-06-13 15:18:11,347 -- ci service found: github-actions
info - 2024-06-13 15:18:11,708 -- Process Report creating complete
info - 2024-06-13 15:18:11,708 -- Finished creating report successfully --- {"response": "{\"external_id\":\"039349cd-ac77-4ec4-9098-77e53c2bad4a\",\"created_at\":\"2024-06-13T15:12:30.783042Z\",\"commit_sha\":\"3e0902ca634ee1b94233e4441118f517414cb030\",\"code\":null}"}
==> Running command '/Users/runner/work/_actions/codecov/codecov-action/v4/dist/codecov do-upload'
/Users/runner/work/_actions/codecov/codecov-action/v4/dist/codecov do-upload --git-service github -n 3.12 macos-14 -C 3e0902ca634ee1b94233e4441118f517414cb030
info - 2024-06-13 15:18:12,515 -- ci service found: github-actions
warning - 2024-06-13 15:18:12,584 -- No swift data found.
warning - 2024-06-13 15:18:12,814 -- No gcov data found.
info - 2024-06-13 15:18:12,815 -- Generating coverage.xml report in /Users/runner/work/matplotlib/matplotlib
info - 2024-06-13 15:18:26,254 -- Wrote XML report to coverage.xml
info - 2024-06-13 15:18:26,459 -- Found 3 coverage files to report
info - 2024-06-13 15:18:26,460 -- > /Users/runner/work/matplotlib/matplotlib/ci/schemas/codecov.json
info - 2024-06-13 15:18:26,460 -- > /Users/runner/work/matplotlib/matplotlib/coverage.xml
info - 2024-06-13 15:18:26,460 -- > /Users/runner/work/matplotlib/matplotlib/info.lcov
info - 2024-06-13 15:18:27,181 -- Your upload is now processing. When finished, results will be available at: https://app.codecov.io/github/matplotlib/matplotlib/commit/3e0902ca634ee1b94233e4441118f517414cb030
info - 2024-06-13 15:18:27,492 -- Process Upload complete

Not clear why one of the detected it was in a forked repo and decided it did not need a token...

@rcomer
Copy link
Member

rcomer commented Jun 13, 2024

I confess I have developed a habit of ignoring codecov unless it reports a problem on the patch. Perhaps I should not do that…

@saranti saranti deleted the subfigincolumn branch June 14, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@rcomer rcomer rcomer approved these changes

Assignees
No one assigned
Labels
topic: figures and subfigures
Projects
None yet
Milestone
v3.10.0
Development

Successfully merging this pull request may close these issues.

[Bug]: subfigures are added in column major order
3 participants
@saranti @tacaswell @rcomer
Morty Proxy This is a proxified and sanitized view of the page, visit original site.