Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Avoid modifying user input to Axes.bar #27921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Mar 14, 2024

PR summary

The error_kw parameter is a dictionary, on which setdefault is called, which would modify user input.

I know we always try to avoid modifying user input, but I couldn't find any tests for it, so I didn't add any.

PR checklist

lib/matplotlib/axes/_axes.py Outdated Show resolved Hide resolved
The `error_kw` parameter is a dictionary, on which `setdefault` and
`pop` are called, which would modify user input.
@tacaswell tacaswell added this to the v3.8.4 milestone Mar 14, 2024
@tacaswell tacaswell merged commit 7164087 into matplotlib:main Mar 14, 2024
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Mar 14, 2024
@QuLogic QuLogic deleted the bar-modify branch March 14, 2024 19:49
QuLogic added a commit that referenced this pull request Mar 14, 2024
…921-on-v3.8.x

Backport PR #27921 on branch v3.8.x (Avoid modifying user input to Axes.bar)
@ksunden ksunden mentioned this pull request Apr 4, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.