Don't clip PowerNorm inputs < vmin #27589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
tacaswell
previously approved these changes
Jan 3, 2024
QuLogic
reviewed
Jan 4, 2024
393b29f to
b4701cd
Compare
dstansby
commented
Jan 6, 2024
| f, ax = plt.subplots() | ||
| cb = Colorbar(ax, norm=PowerNorm(gamma=0.5, vmin=0.0, vmax=1.0), | ||
| orientation='vertical', extend='both') | ||
| assert cb._values[0] >= 0.0 |
There was a problem hiding this comment.
This check came in with #11610, but from that PR it seems like it's enough just to add the colorbar and check no error or warning is raised. It's expected that _values now has a value < 0 with this PR.
tacaswell
reviewed
Jan 8, 2024
|
I think going with linear is better because it is invertable, but could we have also fixed the colorbar issue more narrowly by setting the under values to |
QuLogic
reviewed
Jan 9, 2024
Co-authored-by: Thomas A Caswell <tcaswell@gmail.com>
Yes, setting everything under to -1 also fixes the colorbar issue. |
tacaswell
approved these changes
Jan 9, 2024
QuLogic
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
This updates the behaviour of
PowerNormto linearly normalize input values < vmin, instead of clipping them.Fixes #25239; replaces #25256. See discussion at #25256 for more context on this.
PR checklist