Attempted to add test_pcolorfast in test_datetime.py #27450
Conversation
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
|
Wait... what's happening with all the test fails...? |
|
Thank you for working this! One of the explicit goals of writing these tests was in fact to find places where our unit handling could be better/methods that should participate in unit conversions but don't. Could you create an issue to help us track it? We may not merge this PR before that is resolved, since actually passing |
|
I've opened #27526 to track the missing unit handling in |
PR summary
Attempted to add code to
test_pcolorfastintest_datetime.pyas requested in #26864Based on my researches and shallow understandings of the code, the original function
pcolorfast()does not seem to directly support inputs of typedatetime.datetimeornumpy.datetime64; therefore I have useddate2num()to make the graph print correctly.I am (almost) new to GitHub and entirely new to OSS contributions so I apologize ahead if I have made mistakes or caused trouble. Please feel free to point out my flaws and mistakes so that I can correct them.
The outputted graph is as follows:
PR checklist