Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Added test_hist2d #27418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
Loading
from
Open

Added test_hist2d #27418

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
021d6c9
Added test_hist2d
Dec 1, 2023
ef7482a
Update lib/matplotlib/tests/test_datetime.py
rupink Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 37 additions & 3 deletions 40 lib/matplotlib/tests/test_datetime.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,12 +355,46 @@ def test_hist(self):
weights=values3
)

@pytest.mark.xfail(reason="Test for hist2d not written yet")
@mpl.style.context("default")
def test_hist2d(self):
fig, ax = plt.subplots()
ax.hist2d(...)
mpl.rcParams["date.converter"] = 'concise'

start_date = datetime.datetime(2023, 10, 1)
time_delta = datetime.timedelta(days=1)

values1 = np.random.randint(1, 10, 30)
values2 = np.random.randint(1, 10, 30)
values3 = np.random.randint(1, 10, 30)
Comment on lines +365 to +367
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to use randomness, you'll need to set a seed (we use 19680801 for tests).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense


x_values = mpl.dates.date2num([start_date + i * time_delta for i in range(30)])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

date2num means you are passing numbers into hist2d. We want to test actual dates.


# Using Axes.hist2d
fig, (ax1, ax2, ax3) = plt.subplots(1, 3, constrained_layout=True)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
fig, (ax1, ax2, ax3) = plt.subplots(1, 3, constrained_layout=True)
fig, (ax1, ax2, ax3) = plt.subplots(1, 3, layout='constrained')


# Testing with Axes.hist2d
hist2d1 = ax1.hist2d(
x_values,
values1,
bins=10,
cmap='Blues'
)
Comment on lines +375 to +380
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fits in one line, AFAICT.

ax1.set_title('Axes.hist2d - Data 1')

hist2d2 = ax2.hist2d(
x_values,
values2,
bins=10,
cmap='Greens'
)
ax2.set_title('Axes.hist2d - Data 2')

hist2d3 = ax3.hist2d(
x_values,
values3,
bins=10,
cmap='Reds'
)
ax3.set_title('Axes.hist2d - Data 3')
Comment on lines +383 to +397
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see what the difference is between the first plot and these two?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To possibly clarify a bit: it would make more sense to use dates for the y-values as well. So one idea is to keep one of the subplots, swap x and y values for the next (dates on y-axis) and let the third have dates for both x and y-values.

@mpl.style.context("default")
def test_hlines(self):
mpl.rcParams["date.converter"] = 'concise'
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.