-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Add a section to Highlight past winners for JDH plotting contest in docs #27021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added a link to past winners for the JDH plotting contest in fixing issue matplotlib#11129
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
doc/users/resources/index.rst
Outdated
========= | ||
|
||
|
||
[Past winners for JDH plotting contest](https://jhepc.github.io/gallery.html) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you bullet point this one as well? Also, this file uses RST syntax, not Markdown. You can learn about RST here: https://www.sphinx-doc.org/en/master/usage/restructuredtext/basics.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing that out, changed it.
changed formatting on JDH plotting link to RST syntax.
@Tahaabdul You can see the staged docs here: https://output.circle-artifacts.com/output/job/f699e534-516d-4ca4-bb70-50ba920cfe39/artifacts/0/doc/build/html/users/resources/index.html |
Could you also change the title of this pull request to something more descriptive? |
realigned contest link, and author items under galleries section to render on same line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alignment looks good! I'll let a matplotlib maintainer take it from here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Tahaabdul (and @pamelafox for the review help!)
BTW, I squashed the commits here as I assume you don't care about the history. |
PR summary
PR checklist