Remove a redundant comparison that raises an exception in Python 3 #2685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphinx.__version__ is a string, 1.1 is a float: the comparison always returns True in Python 2. In Python 3 however the > <, <=, > and >= operators will raise a TypeError exception when > comparing a complex number with another built-in numeric type, when > the objects are of different types that cannot be compared, or in > other cases where there is no defined ordering [0]. str and float are such unorderable types. [0] http://docs.python.org/3.3/library/stdtypes.html#comparisons
|
Thanks. It's obsolete, anyway, so definitely makes sense to merge this. |
mdboom
added a commit
that referenced
this pull request
Dec 16, 2013
Remove a redundant comparison that raises an exception in Python 3
mdboom
added a commit
that referenced
this pull request
Dec 16, 2013
Remove a redundant comparison that raises an exception in Python 3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sphinx.version is a string, 1.1 is a float: the comparison always
returns True in Python 2. In Python 3 however the
[0]. str and float are such unorderable types.
[0] http://docs.python.org/3.3/library/stdtypes.html#comparisons