Close a figure with a type long or uuid figure number #2683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -516,8 +516,12 @@ def close(*args): | ||
| arg = args[0] | ||
| if arg == 'all': | ||
| _pylab_helpers.Gcf.destroy_all() | ||
| elif isinstance(arg, int): | ||
| elif isinstance(arg, int) or isinstance(arg, long): |
There was a problem hiding this comment.
I think this needs to be ```isinstance(arg, six.integer_types)'''.
|
👍 (and note to self, I think we merge this on master only). |
|
@JamesMakela would you mind squashing this down to a single commit and doing a force-push? Then I will merge it. |
Creating a figure with a type(long) figure number is allowed, so closing should be similarly allowed. close figure with type UUID as figure number if we can create a figure with a number that is type UUID, then it is reasonable to be able to close the figure with it as well. make the allowed int types Python 2 and 3 compatible
|
Alright, I believe it is done. |
|
test failure was un-related. Restarted it anyway. |
efiring
added a commit
that referenced
this pull request
Dec 19, 2013
Close a figure with a type long or uuid figure number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If it is possible to create a figure using a figure number that is a type long or a type UUID, then it stands to reason that you should be able to close the figure using that same figure number.