-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Removed unnecessary origin keywords #26608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
timhoffm
merged 9 commits into
matplotlib:main
from
gautamsagar99:gautamsagar99/contourf-origin#26600
Aug 31, 2023
Merged
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
b0aaeb7
Removed unnecessary origin keywords
gautamsagar99 6fcdd63
Merge branch 'matplotlib:main' into gautamsagar99/contourf-origin#26600
gautamsagar99 3525d30
Added Contourf example using origin
gautamsagar99 cd74288
Build the documentation for Contourf_demo.py
gautamsagar99 6bd68f5
Modified Documentation for Contourf_demo.py
gautamsagar99 cf7afd7
Optimized the documentation for Contourf_demo.py
gautamsagar99 0e1a587
Modified documentation for Contourf_demo.py
gautamsagar99 9deecdd
Enhanced documentation for Contourf_demo.py
gautamsagar99 4185323
Final Enhancement in documentation for Contourf_demo.py
gautamsagar99 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our convention is Title case - first word in title upper case, everything else lower case.
Also origin isn't a customization , it's a tell Matplotlib my data needs to be read from the lower left or upper left corner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@story645 Thank you for sharing. I will update the changes and push it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi, changes aren't showing up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh is it, Let me recommit and push the latest changes again.