-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
[GSoD] refine gallery examples (titles, scope, link) #26456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- add link to axes intro in user guide - remove text that doesn't belong in gallery example - add descriptive titles to dolphins, donuts, and firefox
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
@@ -4,6 +4,8 @@ | ||
=================== | ||
|
||
This figure shows the name of several matplotlib elements composing a figure | ||
|
||
To see detailed information, see :ref:`axes_intro`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the docs build
/home/circleci/project/doc/gallery/showcase/anatomy.rst:30: WARNING: undefined label: 'axes_intro'
5d09221
to
a7bc6da
Compare
@@ -4,6 +4,8 @@ | ||
=================== | ||
|
||
This figure shows the name of several matplotlib elements composing a figure | ||
|
||
To see detailed information, see :ref:`axes_intro`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To see detailed information, see :ref:`axes_intro`. | |
To see detailed information, see :doc:`axes_intro`. |
axes_intro doesn't have a label - probably should but that's a separate issue. https://github.com/matplotlib/matplotlib/blob/main/galleries/users_explain/axes/axes_intro.rst?plain=1
Hey @esibinga sorry this got stalled out, do you have bandwidth to finish? |
PR summary
small cleanup projects:
@story645
PR checklist