Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[GSoD] refine gallery examples (titles, scope, link) #26456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
Loading
from

Conversation

esibinga
Copy link
Collaborator

@esibinga esibinga commented Aug 4, 2023

PR summary

small cleanup projects:

  • add link to axes intro in user guide
  • remove text that doesn't belong in gallery example
  • add descriptive titles to dolphins, donuts, and firefox

@story645

PR checklist

- add link to axes intro in user guide
- remove text that doesn't belong in gallery example
- add descriptive titles to dolphins, donuts, and firefox
@story645 story645 added the Documentation: examples files in galleries/examples label Aug 4, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@@ -4,6 +4,8 @@
===================

This figure shows the name of several matplotlib elements composing a figure

To see detailed information, see :ref:`axes_intro`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the docs build

/home/circleci/project/doc/gallery/showcase/anatomy.rst:30: WARNING: undefined label: 'axes_intro'

@story645 story645 self-assigned this Aug 24, 2023
@esibinga esibinga force-pushed the link-to-user-guide branch from 5d09221 to a7bc6da Compare August 25, 2023 19:14
@@ -4,6 +4,8 @@
===================

This figure shows the name of several matplotlib elements composing a figure

To see detailed information, see :ref:`axes_intro`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To see detailed information, see :ref:`axes_intro`.
To see detailed information, see :doc:`axes_intro`.

axes_intro doesn't have a label - probably should but that's a separate issue. https://github.com/matplotlib/matplotlib/blob/main/galleries/users_explain/axes/axes_intro.rst?plain=1

@story645
Copy link
Member

Hey @esibinga sorry this got stalled out, do you have bandwidth to finish?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation: examples files in galleries/examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.