Rename an internal parameter of _label_outer_x/yaxis() #26454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failures are method calls which passed the parameter explicitly (and one line that grew too long with the longer name) |
`check_patch` does not explain what this parameter is achieving.
456ae86 to
88e1353
Compare
|
Ah, you shouldn't blindly trust refactoring. - The code in tests was too dynamic so that PyCharm could not infer that this should be changed as well. - Fixed. |
rcomer
approved these changes
Aug 5, 2023
ksunden
approved these changes
Aug 6, 2023
timhoffm
pushed a commit
to timhoffm/matplotlib
that referenced
this pull request
Aug 6, 2023
…ectilinear Rename an internal parameter of _label_outer_x/yaxis()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check_patchdoes not explain what this parameter is achieving.