Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

DOC: add remote upstream #25828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions 24 doc/devel/development_setup.rst
Original file line number Diff line number Diff line change
Expand Up @@ -59,13 +59,29 @@ should replace ``<your-username>`` with your GitHub username):


This will place the sources in a directory :file:`matplotlib` below your
current working directory, set up the ``origin`` remote to point to your own
fork, and set up the ``upstream`` remote to point to the Matplotlib main
repository (see also `Managing remote repositories <https://docs.github.com/en/get-started/getting-started-with-git/managing-remote-repositories>`__.)
Change into this directory before continuing::
current working directory and set up the ``origin`` remote to point to your own
Copy link
Member

@timhoffm timhoffm May 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
current working directory and set up the ``origin`` remote to point to your own
current working directory and set up a remote repository ``origin`` pointing to your own

Is this clearer? If so, same wording should be applied to upstream

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really really really like this minor change - it addresses my concerns by explaining what the words are. Can I open a follow on PR to make this change?

fork. Change into this directory before continuing::

cd matplotlib

Now set up the ``upstream`` remote to point to the Matplotlib main repository,
so that you can access the latest changes there (see also `Managing remote repositories
<https://docs.github.com/en/get-started/getting-started-with-git/managing-remote-repositories>`__.):

.. tab-set::

.. tab-item:: https

.. code-block:: bash

git remote add upstream https://github.com/matplotlib/matplotlib.git

.. tab-item:: ssh

.. code-block:: bash

git remote add upstream git@github.com:matplotlib/matplotlib.git

.. note::

For more information on ``git`` and ``GitHub``, check the following resources.
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.