Add comment on issues marked 'good first issue' #25735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f6708ca to
938e01b
Compare
|
@melissawm friendly reminder to have a look and possibly suggest a better wording. (I think we will have to try it to see how it works, but this is a reasonably well used action.) |
melissawm
reviewed
May 24, 2023
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Co-authored-by: Melissa Weber Mendonça <melissawm@gmail.com>
|
pre-commit doesn't like it; some trailing whitespace slipped in. |
oscargus
commented
May 25, 2023
|
Fixed that. Make sure to squeeze when merging. |
QuLogic
approved these changes
May 25, 2023
|
It seems to work: #25942 (although the link text makes the text in the comment line break in an ugly way because of the line length limitation). |
devRD
pushed a commit
to devRD/matplotlib
that referenced
this pull request
Jun 5, 2023
* Add comment on issues marked 'good first issue' * Apply suggestions Co-authored-by: Melissa Weber Mendonça <melissawm@gmail.com> * Remove trailing white space --------- Co-authored-by: Melissa Weber Mendonça <melissawm@gmail.com>
melissawm
added a commit
to melissawm/matplotlib
that referenced
this pull request
Jun 15, 2023
* Add comment on issues marked 'good first issue' * Apply suggestions Co-authored-by: Melissa Weber Mendonça <melissawm@gmail.com> * Remove trailing white space --------- Co-authored-by: Melissa Weber Mendonça <melissawm@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Who knows if this works? @melissawm feel free to update the text.
PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst