Add test for Path.contains_path #25730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23dbd33 to
4daa7bd
Compare
|
doc failure is due to the issues with the website. |
tacaswell
reviewed
Apr 20, 2023
tacaswell
reviewed
Apr 20, 2023
4daa7bd to
68856dc
Compare
tacaswell
approved these changes
Apr 20, 2023
timhoffm
approved these changes
Apr 20, 2023
There was a problem hiding this comment.
Can we add a test case with a non convex polygon so that all points of the other are inside, but some part of the edge goes outside; e.g. (sorry for the poor formatting, I’m on mobile)
-0.1, -0.1
-0.1, 1.2
0.5, 0.8
1.1, 1.2
1.1, -0.1
This is a rectangle with a kink at the top so that all nodes of the unit square are inside, but the top edge of the unit square is partially outside.
68856dc to
5233b32
Compare
|
I've added such a test (third one). |
timhoffm
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This was untested.
PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst