Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Backport PR #25129 on branch v3.7.x (Undeprecate Cursor event handlers) #25160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ksunden merged 2 commits into from
Feb 7, 2023
Merged

Backport PR #25129 on branch v3.7.x (Undeprecate Cursor event handlers) #25160

ksunden merged 2 commits into from
Feb 7, 2023

Conversation

@meeseeksmachine
Copy link
Contributor

@meeseeksmachine meeseeksmachine commented Feb 6, 2023

Backport PR #25129: Undeprecate Cursor event handlers

@lumberbot-app lumberbot-app bot added this to the v3.7.0 milestone Feb 6, 2023
@lumberbot-app lumberbot-app bot added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Feb 6, 2023
@ksunden
Copy link
Member

ksunden commented Feb 6, 2023

Circle test failure is real, related to #22329

This was fixed by #25106, which the backport failed for... I'm just going to roll that backport into this backport.

@anntzer @ksunden
Fix cursor_demo wrt. Line2D.set_x/ydata not accepting scalars anymore.
6a3209c 
Trying to run the example prior to the PR would result in exceptions
being thrown on mouse moves.

Manual backport of matplotlib#25106 rolled into backport of matplotlib#25129 (backport pr matplotlib#25160)
@ksunden ksunden mentioned this pull request Feb 6, 2023
Merged
6 tasks
jklymak
jklymak approved these changes Feb 6, 2023
View reviewed changes
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ksunden feel free to self merge if you are happy w/ the state of this...

@ksunden ksunden merged commit 8e420f8 into matplotlib:v3.7.x Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jklymak jklymak jklymak approved these changes

Assignees

No one assigned

Labels

Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.

Projects

None yet

Milestone

v3.7.0

Development

Successfully merging this pull request may close these issues.

4 participants

@meeseeksmachine @ksunden @jklymak @anntzer
Morty Proxy This is a proxified and sanitized view of the page, visit original site.