Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Consistently document shapes as (M, N), not MxN. #25120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 1, 2023
Merged

Consistently document shapes as (M, N), not MxN. #25120

merged 1 commit into from
Feb 1, 2023

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jan 31, 2023

We already mostly use "(M, N)", but there were still quite a few instances of "MxN". Also add a helper to generate the error messages in extensions.

PR Summary

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@anntzer anntzer force-pushed the mxn branch 2 times, most recently from f277f38 to 75f1dcf Compare January 31, 2023 23:07
story645
story645 approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@story645 story645 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments are take or leave/can self merge or tell me to merge
ETA: forgot it code and needs 2 reviews 🤦‍♀️

lib/matplotlib/patches.py Outdated Show resolved Hide resolved
src/_backend_agg_wrapper.cpp Outdated Show resolved Hide resolved
src/mplutils.h Show resolved Hide resolved
@anntzer
Consistently document shapes as (M, N), not MxN.
c5483f7 
We already mostly use "(M, N)", but there were still quite a few
instances of "MxN".  Also add a helper to generate the error messages in
extensions.
@tacaswell tacaswell added this to the v3.8.0 milestone Feb 1, 2023
@tacaswell tacaswell merged commit f3938be into matplotlib:main Feb 1, 2023
@anntzer anntzer deleted the mxn branch February 1, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@story645 story645 story645 approved these changes

Assignees
No one assigned
Labels
Documentation Maintenance
Projects
None yet
Milestone
v3.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @tacaswell @story645
Morty Proxy This is a proxified and sanitized view of the page, visit original site.