Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

FIX: be more forgiving in default draw wrapper #24720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 14, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions 4 lib/matplotlib/artist.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,14 @@ def _prevent_rasterization(draw):
# (e.g., change in dpi).

@wraps(draw)
def draw_wrapper(artist, renderer):
def draw_wrapper(artist, renderer, *args, **kwargs):
if renderer._raster_depth == 0 and renderer._rasterizing:
# Only stop when we are not in a rasterized parent
# and something has been rasterized since last stop.
renderer.stop_rasterizing()
renderer._rasterizing = False

return draw(artist, renderer)
return draw(artist, renderer, *args, **kwargs)

draw_wrapper._supports_rasterization = False
return draw_wrapper
Expand Down
13 changes: 13 additions & 0 deletions 13 lib/matplotlib/tests/test_artist.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
import matplotlib.transforms as mtransforms
import matplotlib.collections as mcollections
import matplotlib.artist as martist
import matplotlib.backend_bases as mbackend_bases
import matplotlib as mpl
from matplotlib.testing.decorators import check_figures_equal, image_comparison

Expand Down Expand Up @@ -549,3 +550,15 @@ class Gen2(Gen1):

assert 'draw' not in Gen2.__dict__
assert Gen2.draw is Gen1.draw


def test_draw_wraper_forward_input():
class TestKlass(martist.Artist):
def draw(self, renderer, extra):
return extra

art = TestKlass()
renderer = mbackend_bases.RendererBase()

assert 'aardvark' == art.draw(renderer, 'aardvark')
assert 'aardvark' == art.draw(renderer, extra='aardvark')
Morty Proxy This is a proxified and sanitized view of the page, visit original site.