TST: Set explicit styles for image tests #24709
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Turns out that these are not all, but all that was found in my IDE... I was surprised that it wasn't that many, but clearly I was wrong. Anyway, I expected to do this is steps, so this is one step. |
timhoffm
reviewed
Dec 13, 2022
| @image_comparison(['agg_filter.png'], remove_text=True) | ||
| # # Update style when regenerating the test image | ||
| @image_comparison(['agg_filter.png'], remove_text=True, | ||
| style=("classic", "_classic_test_patch")) |
There was a problem hiding this comment.
Having this baseline + patch style combination is a bit bulky given that we write it all over the tests. I suggest to create a _classic_test style that hard-coded merges both.
There was a problem hiding this comment.
@oscargus were you going to update this? Overall I think this is a great idea...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Change all image test styles to explicit so that it is possible to change the default at some later stage.
PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst