Addresses issue #24617 adding setters/getters for Figure #24696
Conversation
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
|
@garveyz2 thanks for your work on this. Is it ready to be reviewed? If so you should see a "Ready for review" button which will take the "draft" status off it. |
|
Hi @rcomer, |
|
Thank you @NoyHanan. Please create a new branch and a new PR referencing this one. You could |
|
I am going to close this PR as abandoned. Thank you for your effort @garveyz2 I do hope we hear from you again. |
PR Summary
Hello, this is my first contribution to an open-source project. This PR is to address the concerns raised in #24617. I've cherrypicked my solution from a previous PR #21549. I have mainly added setters and getters for subplot params as well as modifying the aliases for size_inches to figsize and layout_engine to layout.
PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst