ellipse class #24568 #24576
ellipse class #24568 #24576
Conversation
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
| """ | ||
| self.pad = pad | ||
|
|
||
| def __call__(self,width, height, mutation_size): |
There was a problem hiding this comment.
| def __call__(self,width, height, mutation_size): | |
| def __call__(self, x0, y0, width, height, mutation_size): |
x0 and y0 are the positions of the text.
You will need to adjust the size, taking pad in to account, for this to work. See the Circle style above.
|
Thank you for this. A test is also required (and it may be good to test it locally as well, right now it is not really close to working unfortunately). |
|
#24596 seems to be solving the same problem, but has tests, I am going to close this PR in favor of #24596 which only needs a fix to the rst markup. Thank you for your work on this @MarceloCMiguel , I hope we will hear from you again! |
PR Summary
PR based on issue #24568
Create a class Ellipse
PR Checklist