Skip to content

Navigation Menu

Sign in

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Forward select Rectangle kwargs to Connection patch #24082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Forward select Rectangle kwargs to Connection patch #24082

wants to merge 3 commits into from

Conversation

ejmercier
Copy link

@ejmercier ejmercier commented Oct 3, 2022 •
edited
Loading

PR Summary

Closes #23424
This bug fix forwards **kwargs from the indicate_inset function into the Connection Patch. It uses a blacklist to decide which ones should be passed as patch_kwargs to the Connection Patch and not the Rectangle patch.

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [N/A ] New features are documented, with examples if plot related.
  • [N/A ] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).

@ejmercier ejmercier force-pushed the edgecolor-connector-bug branch from c31fc6f to 6a67b8e Compare October 3, 2022 01:34
@ejmercier ejmercier changed the title Forwarded select Rectangle kwargs to the Conneciton patch Forwarded select Rectangle kwargs to the Connection patch Oct 3, 2022
@oscargus
Copy link
Member

oscargus commented Oct 3, 2022

Thanks! Can you please add a test?

I think a suitable test is to set some of the parameters and then check that the resulting ConnectorPatch have the expected values.

@ejmercier
Copy link
Author

Yes I can add a test. Is there a specific place where I should create it?

@oscargus
Copy link
Member

oscargus commented Oct 4, 2022

I think that test_axes.py would be a good place. https://github.com/matplotlib/matplotlib/blob/main/lib/matplotlib/tests/test_axes.py

QuLogic
QuLogic reviewed Oct 13, 2022
View reviewed changes
lib/matplotlib/axes/_axes.py Outdated Show resolved Hide resolved
lib/matplotlib/axes/_axes.py Outdated Show resolved Hide resolved
@oscargus oscargus changed the title Forwarded select Rectangle kwargs to the Connection patch Forward select Rectangle kwargs to Connection patch Oct 13, 2022
ejmercier and others added 2 commits October 15, 2022 15:33
@ejmercier @QuLogic
Update lib/matplotlib/axes/_axes.py
d3328b0 
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
@ejmercier @QuLogic
Update lib/matplotlib/axes/_axes.py
8137712 
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
@timhoffm timhoffm mentioned this pull request Oct 31, 2022
Closed
@rcomer
Copy link
Member

rcomer commented Jan 30, 2023

Hi @ejmercier are you still interested in working on this one? It looks like it still needs a test.

I'm going to mark this as "draft" for now. Please mark it as "ready for review" when you are ready. In the meantime, if you need help, feel free to ask questions here. Or you may prefer to ask them in our incubator gitter room.

@rcomer rcomer marked this pull request as draft January 30, 2023 19:28
@ejmercier
Copy link
Author

@rcomer thanks for checking up! I'm still looking to work on this. I'll plan to write the test soon and move it out of drafts! If I have any questions I'll reach out

@rcomer
Copy link
Member

rcomer commented Sep 18, 2024

The target issue here has now been addressed as part of a larger change in #27996. Thank you for your work here @ejmercier.

@rcomer rcomer closed this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic left review comments

Assignees
No one assigned
Labels
status: needs rebase status: needs tests status: superseded
Projects
First Time Contributors
Status: Waiting for author
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Axes.indicate_inset(linewidth=...) doesn't affect connectors
4 participants
@ejmercier @oscargus @rcomer @QuLogic
Morty Proxy This is a proxified and sanitized view of the page, visit original site.