Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Leave out barh from the basic plot types. #23631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

timhoffm
Copy link
Member

bar / barh was the only plot type mentioning two
functions, but the plot only showed the vertial one
anyway.

IHMO we can leave out barh. It's mentionend in the
"See also" section of bar. (But I'm open to leaving
a comment in the plot type description if desired -
I mainly want to remove it from the title, because it's
the only one spanning two lines:

image
)

`bar` / `barh` was the only plot type mentioning two
functions, but the plot only showed the vertial one
anyway.

IHMO we can leave out `barh`. It's mentionend in the
"See also" section of `bar`. (But I'm open to leaving
a comment in the plot type description if desired -
I mainly want to remove it from the title.)
@timhoffm timhoffm added this to the v3.6.0 milestone Aug 15, 2022
@story645
Copy link
Member

story645 commented Aug 16, 2022

But I'm open to leaving a comment in the plot type description if desired

I think this PR can be merged w/o that (feel free to self merge if you agree), but that it either might be a good idea to add notes/see alsos/etc on the plot_types plots when there's a very highly related functionality - like the barh or stacked bars or streamgraphs or it risks making the examples cluttered.

@jklymak
Copy link
Member

jklymak commented Aug 16, 2022

It used to be the same as the cheatsheet:

======================
bar[h](x, height, ...)
======================

@timhoffm
Copy link
Member Author

@story645 Thanks for the comment. I‘ll merge as is for now. I fundamentally agree that we could group together related functionality. But that goes in a slightly different direction than the current plot types, which are 1) actually function and not type based (*) and 2) intentionally are limited to a few selected types. So I leave that discussion for later.

@jklymak Thanks for the reminder. I think I’ve discussed it before that IMHO [h] is not easily understandable without context, in particular not, together with the parameter names x, height. I therefore don’t want to go that route.

(*) E.g. There’s overlap between plot with markers only and scatter; we have a few step-like functions (step, stairs, maybe hist); the mentioned stackedbars isn’t even a single function, but an algorithmic recipe (even more complicated are grouped bars).

@timhoffm timhoffm merged commit abd2f6c into matplotlib:main Aug 16, 2022
@timhoffm timhoffm deleted the doc-plot_types-bar branch August 16, 2022 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.