FIX: reset to original DPI in getstate #23476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a bit of extra caution in extracting the original DPI just in case there is a canvas class that does something very funny and the `_orignial_dpi` attribute does not get set (it is set to the `Figure` instance in the `CanvasBase` init, not in the `Figure` init). closes matplotlib#23471
jklymak
approved these changes
Jul 22, 2022
QuLogic
approved these changes
Jul 22, 2022
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
tacaswell
pushed a commit
to tacaswell/matplotlib
that referenced
this pull request
Jul 22, 2022
Merge pull request matplotlib#23476 from tacaswell/fix/unpickle_dpi FIX: reset to original DPI in getstate (cherry picked from commit 3301248)
QuLogic
added a commit
that referenced
this pull request
Jul 22, 2022
…-v3.5.x Backport PR #23476: FIX: reset to original DPI in getstate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
There is a bit of extra caution in extracting the original DPI
just in case there is a canvas class that does something very funny
and the
_orignial_dpiattribute does not get set (it is set to theFigureinstance in the
CanvasBaseinit, not in theFigureinit).closes #23471
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).