Try running the pgf backend off the article class. #23443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would say this probably needs an API note? |
Apparently the minimal class is problematic from some use cases, and its used discouraged (https://tex.stackexchange.com/questions/42114). This does require loading hyperref using a standard usepackage, though. While we're at it, remove the early font loading, which seems unnecessary too. (Or we should add a test or a comment that shows a case where it's needed.)
|
done. |
oscargus
approved these changes
Jul 22, 2022
QuLogic
added a commit
to QuLogic/matplotlib
that referenced
this pull request
Aug 19, 2022
This follows from matplotlib#23443 where pgf started using `article` instead of `minimal`, but the testing check was not updated for it.
2 tasks
|
Just a small question way after: has the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently the minimal class is problematic from some use cases, and its
used discouraged (https://tex.stackexchange.com/questions/42114).
This does require loading hyperref using a standard usepackage, though.
While we're at it, remove the early font loading, which seems
unnecessary too. (Or we should add a test or a comment that shows a
case where it's needed.)
Closes #18271. Admittedly I don't know for sure that this won't break any use cases, but I don't see how to find that out without trying...
PR Summary
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).