Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

MNT: Use list comprehension #23354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2022
Merged

MNT: Use list comprehension #23354

merged 1 commit into from
Jun 28, 2022

Conversation

oscargus
Copy link
Member

PR Summary

A few loops are rewritten as list comprehensions (which are slightly faster).

PR Checklist

Tests and Styling

  • [N/A] Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [N/A] New features are documented, with examples if plot related.
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).

@oscargus oscargus force-pushed the listcomprehensions branch from a00e2cb to e3fd5eb Compare June 27, 2022 15:02
@oscargus oscargus force-pushed the listcomprehensions branch from e3fd5eb to 7ea33dc Compare June 27, 2022 15:03
@timhoffm timhoffm added this to the v3.6.0 milestone Jun 27, 2022
@QuLogic QuLogic merged commit 5f53d99 into matplotlib:main Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Maintenance
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@oscargus @QuLogic @timhoffm
Morty Proxy This is a proxified and sanitized view of the page, visit original site.