Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Corrected docstring for artist.Artist.set_agg_filter #23168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 2, 2022
Merged

Corrected docstring for artist.Artist.set_agg_filter #23168

merged 2 commits into from
Jun 2, 2022

Conversation

SaumyaBhushan
Copy link
Contributor

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

#23050

github-actions[bot]
github-actions bot reviewed May 31, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@oscargus
Copy link
Member

oscargus commented May 31, 2022 •
edited
Loading

Can you please shorten the lines to 79 characters? (This is where linting complains.)

The ideal way is to change it, do git commit --amend (after adding the file) and then git push origin <branchname> --force-with-lease to avoid multiple commits.

@SaumyaBhushan
Copy link
Contributor Author

@oscargus Please review.

@SaumyaBhushan
Copy link
Contributor Author

@matplotlib/developers

@tacaswell tacaswell added this to the v3.6.0 milestone Jun 2, 2022
@tacaswell tacaswell modified the milestones: v3.6.0, v3.5.3 Jun 2, 2022
@tacaswell tacaswell merged commit 6cba8d9 into matplotlib:main Jun 2, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jun 2, 2022
@tacaswell @meeseeksmachine
Backport PR matplotlib#23168: Corrected docstring for artist.Artist.s…
cb8b291 
…et_agg_filter
@meeseeksmachine meeseeksmachine mentioned this pull request Jun 2, 2022
Merged
@tacaswell
Copy link
Member

Thank you @SaumyaBhushan . Congratulations on your first merged Matplotlib PR 🎉 ! Hopefully we will hear from you again.

@SaumyaBhushan
Copy link
Contributor Author

Thanks a lot @tacaswell 🥳

timhoffm added a commit that referenced this pull request Jun 2, 2022
@timhoffm
Merge pull request #23185 from meeseeksmachine/auto-backport-of-pr-23…
20cda21 
…168-on-v3.5.x

Backport PR #23168 on branch v3.5.x (Corrected docstring for artist.Artist.set_agg_filter)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@tacaswell tacaswell tacaswell approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.5.3
Development

Successfully merging this pull request may close these issues.
3 participants
@SaumyaBhushan @oscargus @tacaswell
Morty Proxy This is a proxified and sanitized view of the page, visit original site.