Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Added my (open access) book #23161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2022
Merged

Added my (open access) book #23161

merged 1 commit into from
May 30, 2022

Conversation

rougier
Copy link
Member

@rougier rougier commented May 29, 2022

Added entry to my (open access) book.
I did not test build (because it's quite simple addition).

doc/users/resources/index.rst Outdated Show resolved Hide resolved
@rougier rougier requested a review from story645 May 29, 2022 19:31
@jklymak
Copy link
Member

jklymak commented May 29, 2022

@rougier unfortunately, its still not passing CI...

doc/users/resources/index.rst Outdated Show resolved Hide resolved
@rougier
Copy link
Member Author

rougier commented May 30, 2022

Ah damn, I pressed commit changes under @timhoffm proposed fix thinking it would modify my repo but I think I've committed my changes to master instead. And the test is still failing. Sorry for all the trouble. False alarm.

@jklymak
Copy link
Member

jklymak commented May 30, 2022

Huh, now the circle CI didn't run! I'll close and reopen...

@jklymak jklymak closed this May 30, 2022
@jklymak jklymak reopened this May 30, 2022
@story645
Copy link
Member

🥳 it builds, but I'm not sure if you're supposed to rebase this into one commit before this gets merged

@jklymak jklymak merged commit dfb7abc into matplotlib:main May 30, 2022
@QuLogic QuLogic added this to the v3.6.0 milestone May 30, 2022
andrew-fennell pushed a commit to andrew-fennell/matplotlib that referenced this pull request Jun 14, 2022
* Added my (open access) book

* Added missing underscore

* Update doc/users/resources/index.rst

Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>

* Removed trailing whitespace

Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.