Update cibuildwheel #23146
Merged
Update cibuildwheel #23146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ee4a7eb to
ac5b0eb
Compare
... instead of manual install and run. This should also trigger automatic dependabot alerts.
Because cibuildwheel switched to pip 21.3 that uses in-tree builds, we need to add an explicit clean step. This is because the FreeType built for 64-bit and 32-bit Windows are not compatible, but as they appear to be named the same, aren't rebuilt for each wheel, causing linker issues when mixed. I'm not sure it's necessary on other platforms as well, but it can't hurt.
a74f4d4 to
2800a03
Compare
|
This should now be working, I believe. Some new features we could possibly enable (later):
|
This is a cross port of matplotlib/mplcairo@2991c72 and matplotlib/mplcairo@2991c72 Fixes matplotlib#23147 Co-authored-by: Antony Lee <anntzer.lee@gmail.com>
2800a03 to
325e547
Compare
|
@QuLogic perhaps you should ping some people who are appropriate to review this? |
tacaswell
reviewed
Jun 30, 2022
tacaswell
approved these changes
Jul 6, 2022
|
So the idea was pulled from mplcairo, but I guess @anntzer should be able to review this as well? |
anntzer
approved these changes
Jul 7, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
In addition, switch from manual install to the GitHub Action they provide.
For the time being, this does not enable any new builds. We can discuss that in a separate PR.
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).