Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Tweak check for IPython pylab mode. #23097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2022
Merged

Tweak check for IPython pylab mode. #23097

merged 1 commit into from
May 22, 2022

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented May 22, 2022

We really only care about whether the attribute is present (even
nowadays, _needmain is always False; it appears to never have changed in
IPython's history).

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@anntzer
Tweak check for IPython pylab mode.
f439574 
We really only care about whether the attribute is present (even
nowadays, _needmain is always False; it appears to never have changed in
IPython's history).
@timhoffm timhoffm merged commit 35ec03c into matplotlib:main May 22, 2022
@timhoffm timhoffm added this to the v3.6.0 milestone May 22, 2022
@anntzer anntzer deleted the ipypylab branch May 22, 2022 19:12
andrew-fennell pushed a commit to andrew-fennell/matplotlib that referenced this pull request Jun 14, 2022
@anntzer @andrew-fennell
Tweak check for IPython pylab mode. (matplotlib#23097)
5fc7e66 
We really only care about whether the attribute is present (even
nowadays, _needmain is always False; it appears to never have changed in
IPython's history).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Maintenance
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @jklymak @timhoffm
Morty Proxy This is a proxified and sanitized view of the page, visit original site.