MNT: Deprecate date_ticker_factory #23081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8a93858 to
711afeb
Compare
timhoffm
reviewed
May 20, 2022
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
|
I merged the suggestion, thanks, so possibly squash and merge. |
timhoffm
approved these changes
May 21, 2022
andrew-fennell
pushed a commit
to andrew-fennell/matplotlib
that referenced
this pull request
Jun 14, 2022
* Deprecate date_ticker_factory * Update doc/api/next_api_changes/deprecations/23081-OG.rst Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com> Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
As discussed in #23013 it may make sense to deprecate
date_ticker_factorysinceAutoDateLocatorandAutoDateFormatterhas been available for 15-16 years.PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).