TST: fully parameterize test_lazy_linux_headless #22801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklymak
approved these changes
Apr 8, 2022
QuLogic
reviewed
Apr 9, 2022
| proc = _run_helper(_lazy_headless, timeout=_test_timeout, MPLBACKEND="") | ||
| @pytest.mark.parametrize("env", _get_testable_interactive_backends()) | ||
| def test_lazy_linux_headless(env): | ||
| tests = [] |
There was a problem hiding this comment.
This is always empty? The test does nothing...
There was a problem hiding this comment.
🤦🏻 and it is broken in other ways. No-op tests do reliably pass!
c11158d to
44e603e
Compare
QuLogic
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This test should run on more than just PyQt5.
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).