Privatize some SVG internal APIs. #21412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and make their parameter non-optional at the same time (which would
also have required a deprecation period otherwise; this is the main
motivation for hiding the entire API).
The parameter is always passed, it doesn't make much sense to call
`generate_transform()` or `generate_css()` with no arg (and get an empty
string), and this avoids having to switch the mutable default {} of
generate_css to None and add None-to-{} logic.
timhoffm
approved these changes
Oct 21, 2021
|
I added a second commit where I noticed another place where we could use _generate_transform. |
QuLogic
approved these changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and make their parameter non-optional at the same time (which would
also have required a deprecation period otherwise; this is the main
motivation for hiding the entire API).
The parameter is always passed, it doesn't make much sense to call
generate_transform()orgenerate_css()with no arg (and get an emptystring), and this avoids having to switch the mutable default {} of
generate_css to None and add None-to-{} logic.
xref #21402
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).