Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Simplify filename tracking in FT2Font. #21379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2021
Merged

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Oct 18, 2021

We don't need to separately track (and maintain refcounts) for
PyFT2Font.fname; we can simply infer it from py_file (the file object)
as needed. Note that if FT2Font was directly constructed with a
file-like arg, the fname attribute (both previously and with this PR) is
the file-like, not its name.

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

We don't need to separately track (and maintain refcounts) for
PyFT2Font.fname; we can simply infer it from py_file (the file object)
as needed.  Note that if FT2Font was directly constructed with a
file-like arg, the fname attribute (both previously and with this PR) is
the file-like, not its name.
@timhoffm timhoffm merged commit 033ba05 into matplotlib:main Oct 21, 2021
@anntzer anntzer deleted the ft2name branch October 21, 2021 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.