Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fix bounds when initialising SpanSelector #20676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2021
Merged

Fix bounds when initialising SpanSelector #20676

merged 1 commit into from
Jul 19, 2021

Conversation

ericpre
Copy link
Member

@ericpre ericpre commented Jul 19, 2021

PR Summary

Fix #20665

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [n/a] New features are documented, with examples if plot related.
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@ericpre
Copy link
Member Author

ericpre commented Jul 19, 2021

@anntzer, this should fix #20665.

anntzer
anntzer reviewed Jul 19, 2021
View reviewed changes
lib/matplotlib/widgets.py Show resolved Hide resolved
@anntzer
Copy link
Contributor

anntzer commented Jul 19, 2021

Thanks for the quick fix! Just one typo (above), otherwise lgtm.

@ericpre ericpre force-pushed the fix_bound_span_selector branch from acb95be to 31a6cc9 Compare July 19, 2021 10:44
anntzer
anntzer approved these changes Jul 19, 2021
View reviewed changes
Copy link
Contributor

@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modulo CI (at least flake8 needs to be placated).

@ericpre ericpre force-pushed the fix_bound_span_selector branch from 31a6cc9 to 5c08ff6 Compare July 19, 2021 10:58
@ericpre
Copy link
Member Author

ericpre commented Jul 19, 2021

flake8 is now pleased!

@jklymak jklymak merged commit 2bc1243 into matplotlib:master Jul 19, 2021
@QuLogic QuLogic added this to the v3.5.0 milestone Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anntzer anntzer anntzer approved these changes

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
topic: widgets/UI
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.

interactive SpanSelector incorrectly forces axes limits to include 0
4 participants
@ericpre @anntzer @jklymak @QuLogic
Morty Proxy This is a proxified and sanitized view of the page, visit original site.