Simplify curvilinear grid examples. #20626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
reviewed
Jul 11, 2021
Comment on lines
+30
to
+31
| def tr(x, y): return x, y - x | ||
| def inv_tr(x, y): return x, y + x |
There was a problem hiding this comment.
Style: I don't think we should put function bodies on the same line (and I'm surprised flake8 doesn't complain). Either give it proper line breaks (preferred), or inline them into `GridHelperCurveLinear using lambdas.
There was a problem hiding this comment.
One liners can be written together, see https://www.python.org/dev/peps/pep-0008/#blank-lines / PyCQA/pycodestyle#823. I can still spread things out if you prefer, just let me know.
timhoffm
approved these changes
Jul 13, 2021
|
Test failure is real: |
Since 8840d6e we ensure that `x` and `y` passed to `tr` and `inv_tr` are already arrays (see the definition of `_UserTransform2D.transform_non_affine`), so we don't need additional casting-to-arrays.
|
Indeed, fixed. |
timhoffm
approved these changes
Jul 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 8840d6e we ensure that
xandypassed totrandinv_trare already arrays (see the definition of
_UserTransform2D.transform_non_affine), so we don't need additionalcasting-to-arrays.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).