Raise if passed invalid kwargs to set_constrained_layout_pads. #20547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
reviewed
Jun 30, 2021
Member
timhoffm
left a comment
There was a problem hiding this comment.
Is there a reason that we cannot make the parameters explicit:
def set_constrained_layout_pads(*, w_pad=None, h_pad=None, wspace=None, hspace=None)
Member
Author
I guess maybe it was to shorten the implementation? But it's still possible in a somewhat succinct manner, so I've changed it. |
7cab385 to
cbd09f4
Compare
timhoffm
approved these changes
Jun 30, 2021
jklymak
approved these changes
Jul 2, 2021
Member
jklymak
left a comment
There was a problem hiding this comment.
Seems good. Though I hope to get rid of all this in the near future ;-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
I was trying to pass
wpadand wondering why it didn't seem to do anything... No deprecation because constrained layout is still 'experimental'.PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).