Plot nothing for incompatible 0 shape in x,y data #20530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacaswell
reviewed
Jun 29, 2021
|
Thanks for working on this @dmatos2012 ! Can you please add a test for this (the example from the original bug report and asserting the length of the returned list is 0 would be perfect). I would also like to see a test added (or point at an existing test) that this does not change the behavior for |
|
Done @tacaswell! I put the test in tests/test_axes.py as there is were I found everything related to plots, but wasnt sure if it was the proper place to put them. Thanks for the feedback! |
tacaswell
approved these changes
Jun 29, 2021
QuLogic
approved these changes
Jun 29, 2021
|
Thanks @dmatos2012 ! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR addresses issue #20452 which would raise ZeroDivisionError when 0 in data shape for plotting. Now, it "does nothing".
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).