matplotlib · QuLogic · Jun 30, 2021 · Jun 16, 2021 · Jun 20, 2021 · QuLogic
diff --git a/lib/matplotlib/tests/test_widgets.py b/lib/matplotlib/tests/test_widgets.py
@@ -254,6 +254,31 @@ def test_CheckButtons():
    check.disconnect(cid)


+def test_TextBox():
+    from unittest.mock import Mock
+    submit_event = Mock()
+    text_change_event = Mock()
+    ax = get_ax()
+
+    tool = widgets.TextBox(ax, 'Evaluate')
+    tool.on_submit(submit_event)
+    tool.on_text_change(text_change_event)
+    tool.set_val('x**2')
+
+    assert tool.text == 'x**2'
+    assert text_change_event.call_count == 1
+
+    tool.begin_typing(tool.text)
+    tool.stop_typing()
+
+    assert submit_event.call_count == 2
+    do_event(tool, '_click')
+    do_event(tool, '_keypress', key='+')
+    do_event(tool, '_keypress', key='5')
+
+    assert text_change_event.call_count == 3
+
+
 @image_comparison(['check_radio_buttons.png'], style='mpl20', remove_text=True)
 def test_check_radio_buttons_image():
    # Remove this line when this test image is regenerated.
-Original file line number
+Diff line change
@@ -254,6 +254,31 @@ def test_CheckButtons():
         check.disconnect(cid)
+    def test_TextBox():
+        from unittest.mock import Mock
+        submit_event = Mock()
+        text_change_event = Mock()
+        ax = get_ax()
+        tool = widgets.TextBox(ax, 'Evaluate')
+        tool.on_submit(submit_event)
+        tool.on_text_change(text_change_event)
+        tool.set_val('x**2')
+        assert tool.text == 'x**2'
+        assert text_change_event.call_count == 1
+        tool.begin_typing(tool.text)
             Copy link

  
      
    
  

  
      

  
  Member


      

  

  
    
      

      
            QuLogic
  

      

      

      


        Jun 18, 2021


      
    

  


        
      
  
  
  
    

    There was a problem hiding this comment.


  

 
  
    

    Choose a reason for hiding this comment

    
      The reason will be displayed to describe this comment to others. Learn more.
    

    
      
      


  


  
    
      It doesn't really make sense to enter text into the box, and not verify that that actually ended up in the box, but instead, replace the text entirely on the submit handler.
If you want to verify that the handlers were called, then set a global, or use a Mock object that counts calls. And to verify that the setters work, just call them directly (and assert a check after.)
    
  
  


    

        
      
  
  
    
  
  
  
    
    Sorry, something went wrong.
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  


          
      
  
    
    
      
        
            
    All reactions
  


          
          
        
      
    

    



    
        
  
    
        
    
  


      
          
  
      
            Copy link

  
      
    
  

  
      

  
    Contributor


      

  Author


  

  
    
      

      
            dmatos2012
  

      

      

      


        Jun 20, 2021


      
    

  


        
      
  
  
  
    

    There was a problem hiding this comment.


  

 
  
    

    Choose a reason for hiding this comment

    
      The reason will be displayed to describe this comment to others. Learn more.
    

    
      
      


  


  
    
      Yes thank you so much, I have modified according to your suggestions.
    
  
  


    

        
      
  
  
    
  
  
  
    
    Sorry, something went wrong.
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  


          
      
  
    
    
      
        
            
    All reactions
+        tool.stop_typing()
+        assert submit_event.call_count == 2
+        do_event(tool, '_click')
+        do_event(tool, '_keypress', key='+')
+        do_event(tool, '_keypress', key='5')
+        assert text_change_event.call_count == 3
     @image_comparison(['check_radio_buttons.png'], style='mpl20', remove_text=True)
     def test_check_radio_buttons_image():
         # Remove this line when this test image is regenerated.
-          Expand Down