Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

add highlight-text to the third party packages list #19939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 11, 2021

Conversation

znstrider
Copy link
Contributor

PR Summary

This adds the highlight-text package to the third party packages list.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@timhoffm
Copy link
Member

Thanks for the PR! Images should not be wider than 900px. Otherwise they will overflow the layout, see

https://56575-1385122-gh.circle-artifacts.com/0/doc/build/html/thirdpartypackages/index.html#highlight-text

Also, please run the image through https://tinypng.com/ so that we don't bloat the repo unnecessarily and save user bandwidth.

@znstrider
Copy link
Contributor Author

Thanks for your reply!

I committed the resized and optimized image.

@timhoffm timhoffm added this to the v3.4-doc milestone Apr 11, 2021
@timhoffm timhoffm merged commit ccd368c into matplotlib:master Apr 11, 2021
@timhoffm
Copy link
Member

Again, thanks for the PR!

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Apr 11, 2021
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Apr 11, 2021
dstansby added a commit that referenced this pull request Apr 12, 2021
…939-on-v3.4.1-doc

Backport PR #19939 on branch v3.4.1-doc (add highlight-text to the third party packages list)
dstansby added a commit that referenced this pull request Apr 12, 2021
…939-on-v3.4.x

Backport PR #19939 on branch v3.4.x (add highlight-text to the third party packages list)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.