Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add emojis to issue template titles #19522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

ianhi
Copy link
Contributor

@ianhi ianhi commented Feb 16, 2021

PR Summary

Follow up to #19521

@ianhi
Copy link
Contributor Author

ianhi commented Feb 16, 2021

These were directly inspired by https://github.com/napari/napari

@jklymak
Copy link
Member

jklymak commented Feb 16, 2021

I understand the sentiment, but I do not think these really help understanding, and they frankly look cheesy to me.

@dopplershift
Copy link
Contributor

@jklymak Is that you think they look cheesy when rendered in the GitHub chooser? I'm kinda ok with them:
image

@jklymak
Copy link
Member

jklymak commented Mar 12, 2021

Sure, it's a taste issue. Where I will be more strenuous in objecting is if they start showing up in milestones and issue labels. You can't easily search on them.

@dopplershift
Copy link
Contributor

Absolutely. I just wanted to clarify, because I was much more OK with them in the UI than I was seeing them in the raw markdown.

@QuLogic
Copy link
Member

QuLogic commented Mar 12, 2021

The problem though, is that emoji display is not necessarily consistent:
image
Here I thought the bug looks more like a snake at that size.

@timhoffm
Copy link
Member

grafik

Windows doesn't look too good either (independent of browser Chrome/Firefox/Edge).

@WeatherGod
Copy link
Member

WeatherGod commented Mar 15, 2021 via email

@jklymak
Copy link
Member

jklymak commented May 10, 2021

The response to this was lukewarm enough that I'll close. But @ianhi if you feel strongly, feel free to re-open and we can come to a final decision! Thanks....

@jklymak jklymak closed this May 10, 2021
@ianhi ianhi deleted the emojis branch May 10, 2021 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.