Move svg basename detection down to RendererSVG. #19495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklymak
approved these changes
Jul 7, 2021
tacaswell
approved these changes
Jul 7, 2021
|
but this has grown merge conflicts. |
|
anyone can merge after rebase and green CI |
This means one fewer argument to track down the call stack (avoiding passing it from print_svg to RendererSVG). Wrapping the file object in a TextIOWrapper (as done in print_svg) forwards the `.name` to the wrapper, so we're fine there.
|
rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means one fewer argument to track down the call stack (avoiding
passing it from print_svg to RendererSVG). Wrapping the file object
in a TextIOWrapper (as done in print_svg) forwards the
.nameto thewrapper, so we're fine there.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).