Make backend_gtk3foo importable on headless environments. #19441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should ultimately make it easier to generate apidocs on CI. The change in value of `cursord` only happens on headless envs, where the module was not importable at all before, so that's not an API break.
tacaswell
approved these changes
May 20, 2021
jklymak
approved these changes
May 20, 2021
QuLogic
added a commit
to QuLogic/matplotlib
that referenced
this pull request
May 21, 2021
This was broken in matplotlib#19441 becuase toolmanager uses a fake version of the toolbar2 class which doesn't have any static (or otherwise) methods.
QuLogic
added a commit
to QuLogic/matplotlib
that referenced
this pull request
May 21, 2021
This was broken in matplotlib#19441 because toolmanager uses a fake version of the toolbar2 class which doesn't have any static (or otherwise) methods.
2 tasks
jklymak
pushed a commit
to jklymak/matplotlib
that referenced
this pull request
Jun 13, 2021
This was broken in matplotlib#19441 because toolmanager uses a fake version of the toolbar2 class which doesn't have any static (or otherwise) methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should ultimately make it easier to generate apidocs on CI.
The change in value of
cursordonly happens on headless envs, wherethe module was not importable at all before, so that's not an API break.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).