Replace gtk3 deprecated APIs that have simple replacements. #19435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- set_double_buffered (deprecated since gtk3.14) is unnecessary, gtk (even gtk2) defaults to being double-buffered (this line of code comes from the old gtk2 backend which used to disable double buffering). https://developer.gnome.org/gtk3/stable/GtkWidget.html#gtk-widget-set-double-buffered - gtk_window_get_pointer is deprecated since gtk3.0. https://developer.gnome.org/gdk3/stable/gdk3-Windows.html#gdk-window-get-pointer - get_window_size_request is deprecated since gtk3.0. Also inline add_widget, which is used exactly once. https://developer.gnome.org/gtk3/stable/GtkWidget.html#gtk-widget-size-request
QuLogic
approved these changes
Feb 3, 2021
timhoffm
approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set_double_buffered (deprecated since gtk3.14) is unnecessary, gtk
(even gtk2) defaults to being double-buffered (this line of code comes
from the old gtk2 backend which used to disable double buffering).
https://developer.gnome.org/gtk3/stable/GtkWidget.html#gtk-widget-set-double-buffered
gtk_window_get_pointer is deprecated since gtk3.0.
https://developer.gnome.org/gdk3/stable/gdk3-Windows.html#gdk-window-get-pointer
get_window_size_request is deprecated since gtk3.0. Also inline
add_widget, which is used exactly once.
https://developer.gnome.org/gtk3/stable/GtkWidget.html#gtk-widget-size-request
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsand runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).