Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Revert "Deprecate setting Line2D's pickradius via set_picker." #19336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2021

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jan 21, 2021

This partially reverts commit a2de5bb (#16154).
(The cleanup to legend_picking.py is kept; using set_picker here there
fine.)

See discussion at #19039 (comment).

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@anntzer anntzer added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Jan 21, 2021
@anntzer anntzer added this to the v3.4.0 milestone Jan 21, 2021
Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is just a straight revert and not any fixing for bool?

lib/matplotlib/artist.py Outdated Show resolved Hide resolved
This partially reverts commit a2de5bb.
(The cleanup to legend_picking.py is kept; using `set_picker` here there
fine.)
@anntzer
Copy link
Contributor Author

anntzer commented Jan 22, 2021

for now, yes

@QuLogic QuLogic merged commit b52aad8 into matplotlib:master Jan 22, 2021
@anntzer anntzer deleted the pickradius branch January 22, 2021 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.