Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Simplify X11 checking for Qt. #19316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2021
Merged

Simplify X11 checking for Qt. #19316

merged 1 commit into from
Jan 18, 2021

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jan 18, 2021

display_is_valid takes care of everything now. Also note that AFAICT
PyQt6 does not export QtX11Extras.

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

display_is_valid takes care of everything now.  Also note that AFAICT
PyQt6 does not export QtX11Extras.
@QuLogic QuLogic merged commit 0d44af3 into matplotlib:master Jan 18, 2021
@QuLogic QuLogic added this to the v3.4.0 milestone Jan 18, 2021
@anntzer anntzer deleted the qtx11 branch January 19, 2021 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.