Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

FIX: process lists for inverse norms #19240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2021
Merged

FIX: process lists for inverse norms #19240

merged 1 commit into from
Jan 5, 2021

Conversation

jklymak
Copy link
Member

@jklymak jklymak commented Jan 5, 2021

PR Summary

Closes #19239 by processing the input for inverse as well as __call__ for _make_norm_from_scale

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@jklymak jklymak added this to the v3.4.0 milestone Jan 5, 2021
@jklymak jklymak force-pushed the fix-process-inverse-norm branch from b308574 to df33f03 Compare January 5, 2021 02:51
QuLogic
QuLogic approved these changes Jan 5, 2021
View reviewed changes
Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how much my review counts since this is what I suggested, but you could consider it @jklymak's reverse review of what I wrote.

@QuLogic QuLogic requested a review from anntzer January 5, 2021 05:09
@jklymak @QuLogic
FIX: process lists for inverse norms
ab34279 
Co-authored-by: QuLogic <quantum.analyst@gmail.com>
@jklymak jklymak force-pushed the fix-process-inverse-norm branch from df33f03 to ab34279 Compare January 5, 2021 05:36
@jklymak
Copy link
Member Author

jklymak commented Jan 5, 2021

Yes, sorry, I should have put you in the commit message... I think I did it right...

@anntzer
Copy link
Contributor

anntzer commented Jan 5, 2021

can merge postci

@jklymak jklymak merged commit 7da6d1c into matplotlib:master Jan 5, 2021
@jklymak jklymak deleted the fix-process-inverse-norm branch January 5, 2021 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@anntzer anntzer anntzer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.

_make_norm_from_scale needs to process values
3 participants
@jklymak @anntzer @QuLogic
Morty Proxy This is a proxified and sanitized view of the page, visit original site.