Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

FIX/TST: recursively remove ticks #19087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 12, 2020
Merged

FIX/TST: recursively remove ticks #19087

merged 2 commits into from
Dec 12, 2020

Conversation

jklymak
Copy link
Member

@jklymak jklymak commented Dec 9, 2020

PR Summary

If we are removing ticks from all the axes in a figure, we should remove them from child axes as well. Needed for #18900.

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@jklymak jklymak added this to the v3.4.0 milestone Dec 9, 2020
@jklymak jklymak force-pushed the fix-recursively-remove-ticks branch from f58fcf5 to f34ccb9 Compare December 9, 2020 21:19
timhoffm
timhoffm reviewed Dec 11, 2020
View reviewed changes
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is internal, so it does not matter too much. But making remove_ax() recursive is a bit odd. I'd put the child for loop explicitly within the ax for loop instead.

@jklymak
Copy link
Member Author

jklymak commented Dec 11, 2020

@timhoffm I'm not following. How can it be recursive if you don't call a function?

@jklymak
Copy link
Member Author

jklymak commented Dec 11, 2020

... sorry, let me clarify - child axes can have their own children, so this has to be recursive.

timhoffm
timhoffm reviewed Dec 11, 2020
View reviewed changes
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see. Then let's make that clear with a docstring.

lib/matplotlib/testing/decorators.py Outdated Show resolved Hide resolved
@jklymak @timhoffm
Update lib/matplotlib/testing/decorators.py
c0a31f0 
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
timhoffm
timhoffm approved these changes Dec 12, 2020
View reviewed changes
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anybody can merge after CI pass.

@QuLogic QuLogic merged commit c1ce1de into matplotlib:master Dec 12, 2020
@jklymak jklymak deleted the fix-recursively-remove-ticks branch December 12, 2020 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
topic: testing
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jklymak @QuLogic @timhoffm
Morty Proxy This is a proxified and sanitized view of the page, visit original site.