Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Spectral plot unit tests #1906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 16, 2013
Merged

Spectral plot unit tests #1906

merged 3 commits into from
Apr 16, 2013

Conversation

toddrjen
Copy link
Contributor

Unit tests for the spectral plot types (specgram, psd, and csd) and corresponding mlab functions.

@mdboom
Copy link
Member

mdboom commented Apr 15, 2013

Very nice and much needed pull request.

I wonder, however, whether we need to test all three of png, pdf and svg for these. The pdf and svg files in particular are quite large. (Yes, I know our test suite already has some files of that size, but all the more reason to avoid expanding further... 😉). Maybe we should test PNG only (as those are the smallest files), unless there is some known bug that shows up only with the other formats. Note, we currently do this for the delaunay triangulation tests for the same reason.

@dmcdougall
Copy link
Member

Yes. Also, there still appears to be some text on some of the output files.

@toddrjen
Copy link
Contributor Author

I've restricted it to only pngs and removed the text from the images

@toddrjen
Copy link
Contributor Author

Fixed for python 2.6

@pelson
Copy link
Member

pelson commented Apr 16, 2013

👍

@mdboom
Copy link
Member

mdboom commented Apr 16, 2013

Looks good -- and thanks for amending the commit so the PDFs and SVGs don't make it into the history.

Merging.

mdboom added a commit that referenced this pull request Apr 16, 2013
@mdboom mdboom merged commit f39cdb6 into matplotlib:master Apr 16, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.