Rework checks for old macosx #18669
Merged
Rework checks for old macosx #18669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This works on MacStadium, and would fix wheel CI builds. |
dopplershift
approved these changes
Oct 6, 2020
dstansby
approved these changes
Oct 6, 2020
dstansby
previously requested changes
Oct 6, 2020
|
Is it? What's the error? All I see is a truncated log in the middle of building FreeType. |
This makes it so we can still compile against old SDKs. Fixes matplotlib#18510.
Python requires the SDK to be at least 10.6.
The constant is 101000, not 10100, but fortunately, this worked anyway since 10.9's constant is 1090, and nothing else was defined in between.
|
I figured it out; older SDKs don't define newer |
jklymak
approved these changes
Oct 8, 2020
|
@dopplershift if you still are OK w/ this, go ahead and merge.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This tweaks the checks to use some slightly more modern macros, and updates the documentation URL. It also changes the compatibility
#defines to be enabled when using an older SDK minimum, instead of when not allowing a new maximum. This seems to not trigger any deprecations, yet allows us to not raise minimum requirements.cc @efiring @dstansby @jkseppan
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsandpydocstyle<4and runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).